Skip to content

Fixed default mime_bundle_repr #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed default mime_bundle_repr #398

wants to merge 2 commits into from

Conversation

@JohanMabille
Copy link
Collaborator

Currently, executing xcpp::display(33) outputs the adress of the variable instead of its value. This PR fixes this error.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.94%. Comparing base (c7628c6) to head (2122ff8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   81.78%   81.94%   +0.15%     
==========================================
  Files          20       21       +1     
  Lines         950      853      -97     
  Branches       87       87              
==========================================
- Hits          777      699      -78     
+ Misses        173      154      -19
Files with missing lines Coverage Δ
include/xcpp/xmime.hpp 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

Files with missing lines Coverage Δ
include/xcpp/xmime.hpp 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

anutosh491
anutosh491 approved these changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (just needs a test I think)

@mcbarton
Copy link
Collaborator

Looks good (just needs a test I think)

I also agree that it needs a test, given its fixing a particular bug.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@anutosh491
Copy link
Collaborator

anutosh491 commented Oct 24, 2025 •
edited
Loading

Hmm the emscripten test added passes

/home/runner/work/xeus-cpp/xeus-cpp/test/test_interpreter.cpp:1086:
TEST SUITE: mime_bundle_repr
TEST CASE:  int
/home/runner/work/xeus-cpp/xeus-cpp/test/test_interpreter.cpp:1094: SUCCESS: REQUIRE( res == expected ) is correct!
  values: REQUIRE( {"text/plain":"42"} == {"text/plain":"42"} )

Probably something else fails. Having a look !

@anutosh491
Copy link
Collaborator

anutosh491 commented Oct 24, 2025 •
edited
Loading

Probably something else fails. Having a look !

Looks like a random crash.
CI uses node 20
Locally checking with 23/24(latest) works as want, with 20 fails.

So an upgrade should just fix this (making an upgrade PR now)

@anutosh491 anutosh491 mentioned this pull request Oct 24, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anutosh491 anutosh491 anutosh491 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JohanMabille @codecov-commenter @mcbarton @anutosh491